ARCHBLOX
/
website
1
0
Fork 0
Code Issues Pull Requests 4 Packages Projects Releases Wiki Activity

Bump fakerphp/faker from 1.21.0 to 1.22.0 #30

Merged
dependabot[bot] merged 1 commits from dependabot/composer/fakerphp/faker-1.22.0 into main 2023-05-23 00:02:20 -05:00
Conversation 1 Commits 1 Files Changed 1 +6 -6
dependabot[bot] commented 2023-05-22 01:12:12 -05:00 (Migrated from github.com)
Copy Link

Bumps fakerphp/faker from 1.21.0 to 1.22.0.

Release notes

Sourced from fakerphp/faker's releases.

v1.22.0

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from fakerphp/faker's changelog.

2023-05-14, v1.22.0

  • Fixed randomElements() to accept empty iterator (#605)
  • Added support for passing an Enum to randomElement() and randomElements() (#620)
  • Started rejecting invalid arguments passed to randomElement() and randomElements() (#642)
Commits
  • f85772a Fix: Update CHANGELOG.md (#628)
  • 22da7f1 composer(deps): bump rector/rector in /vendor-bin/rector (#648)
  • a345d80 composer(deps): bump vimeo/psalm from 5.9.0 to 5.11.0 in /vendor-bin/psalm (#...
  • 176a1f7 composer(deps): bump phpstan/phpstan in /vendor-bin/phpstan (#646)
  • 096f7ff allows passing an enum to randomElement() or randomElements() (#620)
  • cd773f4 Fix: Reject invalid arguments (#642)
  • 71997e4 Fix: Do not configure deprecated braces fixer (#638)
  • ddb0390 Fix: Clean up randomElements() and randomElement() (#639)
  • c374da0 fix name (#641)
  • da0dad1 Fix: Disable findUnusedCode option (#637)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps [fakerphp/faker](https://github.com/FakerPHP/Faker) from 1.21.0 to 1.22.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/FakerPHP/Faker/releases">fakerphp/faker's releases</a>.</em></p> <blockquote> <h2>v1.22.0</h2> <h2>What's Changed</h2> <ul> <li>Remove invalid config reference in <code>README.md</code> by <a href="https://github.com/pierredup"><code>@​pierredup</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/577">FakerPHP/Faker#577</a></li> <li>Remove concept of OS from rector workflow by <a href="https://github.com/DvDty"><code>@​DvDty</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/579">FakerPHP/Faker#579</a></li> <li>composer(deps): bump vimeo/psalm from 5.2.0 to 5.4.0 in /vendor-bin/psalm by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/589">FakerPHP/Faker#589</a></li> <li>composer(deps): bump friendsofphp/php-cs-fixer from 3.13.0 to 3.13.1 in /vendor-bin/php-cs-fixer by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/587">FakerPHP/Faker#587</a></li> <li>composer(deps): bump rector/rector from 0.15.0 to 0.15.2 in /vendor-bin/rector by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/590">FakerPHP/Faker#590</a></li> <li>composer(deps): bump phpstan/phpstan from 1.9.2 to 1.9.4 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/586">FakerPHP/Faker#586</a></li> <li>composer(deps): bump phpstan/phpstan-deprecation-rules from 1.0.0 to 1.1.1 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/588">FakerPHP/Faker#588</a></li> <li>Removed ${var} usage - deprecated in PHP 8.2 by <a href="https://github.com/janlanger"><code>@​janlanger</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/591">FakerPHP/Faker#591</a></li> <li>Removed the name Adolf and similarities by <a href="https://github.com/Joas707"><code>@​Joas707</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/584">FakerPHP/Faker#584</a></li> <li>composer(deps): bump rector/rector from 0.15.2 to 0.15.10 in /vendor-bin/rector by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/598">FakerPHP/Faker#598</a></li> <li>composer(deps): bump friendsofphp/php-cs-fixer from 3.13.1 to 3.14.3 in /vendor-bin/php-cs-fixer by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/595">FakerPHP/Faker#595</a></li> <li>composer(deps): bump vimeo/psalm from 5.4.0 to 5.6.0 in /vendor-bin/psalm by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/596">FakerPHP/Faker#596</a></li> <li>composer(deps): bump phpstan/phpstan from 1.9.4 to 1.9.14 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/597">FakerPHP/Faker#597</a></li> <li>Enhancement: Enable <code>findUnusedBaselineEntry</code> option by <a href="https://github.com/localheinz"><code>@​localheinz</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/599">FakerPHP/Faker#599</a></li> <li>Fix: Avoid ternary statement by <a href="https://github.com/localheinz"><code>@​localheinz</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/600">FakerPHP/Faker#600</a></li> <li>Fix: remove currency HRK by <a href="https://github.com/havekes"><code>@​havekes</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/602">FakerPHP/Faker#602</a></li> <li>composer(deps): bump friendsofphp/php-cs-fixer from 3.14.3 to 3.14.4 in /vendor-bin/php-cs-fixer by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/608">FakerPHP/Faker#608</a></li> <li>composer(deps): bump phpstan/phpstan from 1.9.14 to 1.10.3 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/609">FakerPHP/Faker#609</a></li> <li>composer(deps): bump rector/rector from 0.15.10 to 0.15.19 in /vendor-bin/rector by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/612">FakerPHP/Faker#612</a></li> <li>composer(deps): bump vimeo/psalm from 5.6.0 to 5.7.7 in /vendor-bin/psalm by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/611">FakerPHP/Faker#611</a></li> <li>composer(deps): bump phpstan/phpstan-deprecation-rules from 1.1.1 to 1.1.2 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/610">FakerPHP/Faker#610</a></li> <li>timezone() respects countrycode by <a href="https://github.com/jefhar"><code>@​jefhar</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/607">FakerPHP/Faker#607</a></li> <li>composer(deps): bump phpstan/phpstan from 1.10.3 to 1.10.10 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/622">FakerPHP/Faker#622</a></li> <li>composer(deps): bump vimeo/psalm from 5.7.7 to 5.9.0 in /vendor-bin/psalm by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/623">FakerPHP/Faker#623</a></li> <li>composer(deps): bump friendsofphp/php-cs-fixer from 3.14.4 to 3.15.1 in /vendor-bin/php-cs-fixer by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/624">FakerPHP/Faker#624</a></li> <li>composer(deps): bump rector/rector from 0.15.19 to 0.15.23 in /vendor-bin/rector by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/626">FakerPHP/Faker#626</a></li> <li>composer(deps): bump phpstan/phpstan-deprecation-rules from 1.1.2 to 1.1.3 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/625">FakerPHP/Faker#625</a></li> <li>fix: Empty <code>Traversable</code> in <code>randomElements()</code> by <a href="https://github.com/KentarouTakeda"><code>@​KentarouTakeda</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/605">FakerPHP/Faker#605</a></li> <li>Fix: Split test by <a href="https://github.com/localheinz"><code>@​localheinz</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/627">FakerPHP/Faker#627</a></li> <li>composer(deps): bump phpstan/phpstan from 1.10.10 to 1.10.14 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/632">FakerPHP/Faker#632</a></li> <li>github-actions(deps): bump peter-evans/create-pull-request from 4 to 5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/634">FakerPHP/Faker#634</a></li> <li>composer(deps): bump friendsofphp/php-cs-fixer from 3.15.1 to 3.16.0 in /vendor-bin/php-cs-fixer by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/635">FakerPHP/Faker#635</a></li> <li>composer(deps): bump phpstan/extension-installer from 1.2.0 to 1.3.0 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/633">FakerPHP/Faker#633</a></li> <li>composer(deps): bump rector/rector from 0.15.23 to 0.15.25 in /vendor-bin/rector by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/636">FakerPHP/Faker#636</a></li> <li>Fix: DocBlock by <a href="https://github.com/localheinz"><code>@​localheinz</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/631">FakerPHP/Faker#631</a></li> <li>Fix: Disable <code>findUnusedCode</code> option by <a href="https://github.com/localheinz"><code>@​localheinz</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/637">FakerPHP/Faker#637</a></li> <li>fix name by <a href="https://github.com/etchfoda"><code>@​etchfoda</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/641">FakerPHP/Faker#641</a></li> <li>Fix: Clean up <code>randomElements()</code> and <code>randomElement()</code> by <a href="https://github.com/localheinz"><code>@​localheinz</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/639">FakerPHP/Faker#639</a></li> <li>Fix: Do not configure deprecated <code>braces</code> fixer by <a href="https://github.com/localheinz"><code>@​localheinz</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/638">FakerPHP/Faker#638</a></li> <li>Fix: Reject invalid arguments by <a href="https://github.com/localheinz"><code>@​localheinz</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/642">FakerPHP/Faker#642</a></li> <li>allows passing an <code>enum</code> to <code>randomElement()</code> or <code>randomElements()</code> by <a href="https://github.com/cosmastech"><code>@​cosmastech</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/620">FakerPHP/Faker#620</a></li> <li>composer(deps): bump phpstan/phpstan from 1.10.14 to 1.10.15 in /vendor-bin/phpstan by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/646">FakerPHP/Faker#646</a></li> <li>composer(deps): bump vimeo/psalm from 5.9.0 to 5.11.0 in /vendor-bin/psalm by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/647">FakerPHP/Faker#647</a></li> <li>composer(deps): bump rector/rector from 0.15.25 to 0.16.0 in /vendor-bin/rector by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/648">FakerPHP/Faker#648</a></li> <li>Fix: Update <code>CHANGELOG.md</code> by <a href="https://github.com/localheinz"><code>@​localheinz</code></a> in <a href="https://redirect.github.com/FakerPHP/Faker/pull/628">FakerPHP/Faker#628</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/pierredup"><code>@​pierredup</code></a> made their first contribution in <a href="https://redirect.github.com/FakerPHP/Faker/pull/577">FakerPHP/Faker#577</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/FakerPHP/Faker/blob/main/CHANGELOG.md">fakerphp/faker's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/FakerPHP/Faker/compare/v1.21.0..v1.22.0">2023-05-14, v1.22.0</a></h2> <ul> <li>Fixed <code>randomElements()</code> to accept empty iterator (<a href="https://redirect.github.com/FakerPHP/Faker/issues/605">#605</a>)</li> <li>Added support for passing an <code>Enum</code> to <code>randomElement()</code> and <code>randomElements()</code> (<a href="https://redirect.github.com/FakerPHP/Faker/issues/620">#620</a>)</li> <li>Started rejecting invalid arguments passed to <code>randomElement()</code> and <code>randomElements()</code> (<a href="https://redirect.github.com/FakerPHP/Faker/issues/642">#642</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/FakerPHP/Faker/commit/f85772abd508bd04e20bb4b1bbe260a68d0066d2"><code>f85772a</code></a> Fix: Update CHANGELOG.md (<a href="https://redirect.github.com/FakerPHP/Faker/issues/628">#628</a>)</li> <li><a href="https://github.com/FakerPHP/Faker/commit/22da7f1c91e98560f405ca58893f072df2e07ba1"><code>22da7f1</code></a> composer(deps): bump rector/rector in /vendor-bin/rector (<a href="https://redirect.github.com/FakerPHP/Faker/issues/648">#648</a>)</li> <li><a href="https://github.com/FakerPHP/Faker/commit/a345d80e31ff97f5099fcc5ed3425abb1c539be1"><code>a345d80</code></a> composer(deps): bump vimeo/psalm from 5.9.0 to 5.11.0 in /vendor-bin/psalm (#...</li> <li><a href="https://github.com/FakerPHP/Faker/commit/176a1f786aee4b9ac662d3c394bcecd9554f8b90"><code>176a1f7</code></a> composer(deps): bump phpstan/phpstan in /vendor-bin/phpstan (<a href="https://redirect.github.com/FakerPHP/Faker/issues/646">#646</a>)</li> <li><a href="https://github.com/FakerPHP/Faker/commit/096f7fffd86321604eb648de9735d2787fefea93"><code>096f7ff</code></a> allows passing an <code>enum</code> to <code>randomElement()</code> or <code>randomElements()</code> (<a href="https://redirect.github.com/FakerPHP/Faker/issues/620">#620</a>)</li> <li><a href="https://github.com/FakerPHP/Faker/commit/cd773f417ded084059c010bc672c35c242b7bdc6"><code>cd773f4</code></a> Fix: Reject invalid arguments (<a href="https://redirect.github.com/FakerPHP/Faker/issues/642">#642</a>)</li> <li><a href="https://github.com/FakerPHP/Faker/commit/71997e4f239916913a3580b2174b2724652d5441"><code>71997e4</code></a> Fix: Do not configure deprecated braces fixer (<a href="https://redirect.github.com/FakerPHP/Faker/issues/638">#638</a>)</li> <li><a href="https://github.com/FakerPHP/Faker/commit/ddb039044866c9573e0180d56b077db507cea647"><code>ddb0390</code></a> Fix: Clean up <code>randomElements()</code> and <code>randomElement()</code> (<a href="https://redirect.github.com/FakerPHP/Faker/issues/639">#639</a>)</li> <li><a href="https://github.com/FakerPHP/Faker/commit/c374da04cfce5ab5c2353a248c1f4ed71d2b1b3d"><code>c374da0</code></a> fix name (<a href="https://redirect.github.com/FakerPHP/Faker/issues/641">#641</a>)</li> <li><a href="https://github.com/FakerPHP/Faker/commit/da0dad13b0d8432918b1453cc763e04d7364d739"><code>da0dad1</code></a> Fix: Disable findUnusedCode option (<a href="https://redirect.github.com/FakerPHP/Faker/issues/637">#637</a>)</li> <li>Additional commits viewable in <a href="https://github.com/FakerPHP/Faker/compare/v1.21.0...v1.22.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=fakerphp/faker&package-manager=composer&previous-version=1.21.0&new-version=1.22.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
cloudflare-pages[bot] commented 2023-05-22 01:12:14 -05:00 (Migrated from github.com)
Copy Link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: adc6d27
Status: ✅  Deploy successful!
Preview URL: https://6d0d8a69.archblox.pages.dev
Branch Preview URL: https://dependabot-composer-fakerphp.archblox.pages.dev

View logs

## Deploying with &nbsp;<a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a> &nbsp;Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>adc6d27</code> </td></tr> <tr><td><strong>Status:</strong></td><td>&nbsp;✅&nbsp; Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://6d0d8a69.archblox.pages.dev'>https://6d0d8a69.archblox.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://dependabot-composer-fakerphp.archblox.pages.dev'>https://dependabot-composer-fakerphp.archblox.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/archblox/6d0d8a69-e695-4f06-9598-04fd09698b58)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update Javascript code

  
php

Pull requests that update Php code

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
javascript
php
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ARCHBLOX/website#30
No description provided.
Delete Branch "dependabot/composer/fakerphp/faker-1.22.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?