From f4a5e735d104a25321e2878564f7c4e8d6a56147 Mon Sep 17 00:00:00 2001
From: Conkley
Date: Tue, 26 Jul 2022 11:33:19 +1000
Subject: [PATCH] code cleanup
---
app/Http/Controllers/AdminController.php | 6 +-
app/Http/Controllers/FriendController.php | 12 ++--
app/Http/Controllers/HomeController.php | 10 +--
app/Http/Controllers/KeyController.php | 8 +--
app/Http/Controllers/MessageController.php | 6 +-
app/Http/Controllers/PageController.php | 25 +++----
resources/views/admin/tree.blade.php | 12 ++--
resources/views/home.blade.php | 23 ++++---
.../views/pages/mutual_friends.blade.php | 18 ++---
resources/views/pages/profile.blade.php | 66 +++++++++----------
.../views/pages/profile_friends.blade.php | 18 ++---
11 files changed, 99 insertions(+), 105 deletions(-)
diff --git a/app/Http/Controllers/AdminController.php b/app/Http/Controllers/AdminController.php
index cb1c77c..7ad9b68 100644
--- a/app/Http/Controllers/AdminController.php
+++ b/app/Http/Controllers/AdminController.php
@@ -17,9 +17,9 @@ class AdminController extends Controller
public function users(Request $request)
{
if ($request->searchBy == 'name' && $request->has('q')) {
- $users = DB::table('users')->where('name', 'LIKE', '%' . $request->q . '%')->paginate(10);
+ $users = User::where('name', 'LIKE', '%' . $request->q . '%')->paginate(10);
} else if ($request->searchBy == 'id' && $request->has('q')) {
- $users = DB::table('users')->where('id', $request->q)->paginate(10);
+ $users = User::where('id', $request->q)->paginate(10);
} else {
$users = User::paginate(10);
}
@@ -51,6 +51,6 @@ class AdminController extends Controller
'invited_by' => $invited_by,
];
- return view('admin.tree')->with('data', $data);
+ return view('admin.tree')->with($data);
}
}
diff --git a/app/Http/Controllers/FriendController.php b/app/Http/Controllers/FriendController.php
index 2e898cd..71e97f1 100644
--- a/app/Http/Controllers/FriendController.php
+++ b/app/Http/Controllers/FriendController.php
@@ -55,7 +55,7 @@ class FriendController extends Controller
public function accept($id): void
{
$user = Auth::user();
- $recipient = User::find($id);
+ $recipient = User::findOrFail($id);
if (!$user->hasFriendRequestFrom($recipient)) {
abort(404);
@@ -67,7 +67,7 @@ class FriendController extends Controller
public function decline($id): void
{
$user = Auth::user();
- $recipient = User::find($id);
+ $recipient = User::findOrFail($id);
if (!$user->hasFriendRequestFrom($recipient)) {
abort(404);
@@ -79,9 +79,9 @@ class FriendController extends Controller
public function add($id)
{
$user = Auth::user();
- $recipient = User::find($id);
+ $recipient = User::findOrFail($id);
- if (!$recipient || $recipient->id == $user->id) {
+ if ($recipient->id == $user->id) {
abort(404);
}
@@ -96,9 +96,9 @@ class FriendController extends Controller
public function remove($id)
{
$user = Auth::user();
- $recipient = User::find($id);
+ $recipient = User::findOrFail($id);
- if (!$recipient || $recipient->id == $user->id) {
+ if ($recipient->id == $user->id) {
abort(404);
}
diff --git a/app/Http/Controllers/HomeController.php b/app/Http/Controllers/HomeController.php
index 031df9e..aae0dfa 100644
--- a/app/Http/Controllers/HomeController.php
+++ b/app/Http/Controllers/HomeController.php
@@ -25,7 +25,7 @@ class HomeController extends Controller
*/
public function index()
{
- if (auth()->user()) {
+ if (Auth::check()) {
return redirect(route('home'));
}
return view('index');
@@ -43,21 +43,21 @@ class HomeController extends Controller
}
$query->whereIn('user_id', $friendIds)
- ->orWhere('user_id', '=', Auth::id());
- })->orderBy('id', 'desc')->paginate(10, ["*"], "feedPage");
+ ->orWhere('user_id', Auth::id());
+ })->latest()->paginate(10, ["*"], "feedPage");
$data = [
'friends' => $friends,
'posts' => $posts,
];
- return view('home')->with('data', $data);
+ return view('home')->with($data);
}
public function feed_post(Request $request)
{
$request->validate([
- 'status' => 'required|min:3|max:100'
+ 'status' => ['required', 'min:3', 'max:100']
]);
$post = new FeedPost;
diff --git a/app/Http/Controllers/KeyController.php b/app/Http/Controllers/KeyController.php
index fd24dee..e1e3876 100644
--- a/app/Http/Controllers/KeyController.php
+++ b/app/Http/Controllers/KeyController.php
@@ -13,8 +13,8 @@ class KeyController extends Controller
{
public function index()
{
- $fetchKeys = InviteKey::where('created_by', Auth::id())->orderBy('id', 'desc')->get();
- $activeKey = InviteKey::where('created_by', Auth::id())->orderBy('id', 'desc')->first();
+ $fetchKeys = InviteKey::where('created_by', Auth::id())->latest()->get();
+ $activeKey = InviteKey::where('created_by', Auth::id())->latest()->first();
if (!$fetchKeys->isEmpty()) {
if ($activeKey->created_at->addWeek()->gt(Carbon::now())) {
@@ -36,8 +36,8 @@ class KeyController extends Controller
public function create()
{
- $fetchKeys = InviteKey::where('created_by', Auth::id())->orderBy('id', 'desc')->get();
- $activeKey = InviteKey::where('created_by', Auth::id())->orderBy('id', 'desc')->first();
+ $fetchKeys = InviteKey::where('created_by', Auth::id())->latest()->get();
+ $activeKey = InviteKey::where('created_by', Auth::id())->latest()->first();
// Validation
if (!$fetchKeys->isEmpty() && $activeKey->created_at->addWeek()->gt(Carbon::now())) {
diff --git a/app/Http/Controllers/MessageController.php b/app/Http/Controllers/MessageController.php
index df1d868..ab198d2 100644
--- a/app/Http/Controllers/MessageController.php
+++ b/app/Http/Controllers/MessageController.php
@@ -12,21 +12,21 @@ class MessageController extends Controller
{
public function inbox()
{
- $messages = Message::where('sendto_id', Auth::id())->where('deleted', false)->orderBy('id', 'desc')->paginate(10);
+ $messages = Message::where('sendto_id', Auth::id())->where('deleted', false)->latest()->paginate(10);
return view('messages.index')->with('messages', $messages);
}
public function inbox_sent()
{
- $messages = Message::where('user_id', Auth::id())->orderBy('id', 'desc')->paginate(10);
+ $messages = Message::where('user_id', Auth::id())->latest()->paginate(10);
return view('messages.sent')->with('messages', $messages);
}
public function deleted()
{
- $messages = Message::where('sendto_id', Auth::id())->where('deleted', true)->orderBy('id', 'desc')->paginate(10);
+ $messages = Message::where('sendto_id', Auth::id())->where('deleted', true)->latest()->paginate(10);
return view('messages.deleted')->with('messages', $messages);
}
diff --git a/app/Http/Controllers/PageController.php b/app/Http/Controllers/PageController.php
index aa8d500..1c7bee4 100644
--- a/app/Http/Controllers/PageController.php
+++ b/app/Http/Controllers/PageController.php
@@ -27,13 +27,8 @@ class PageController extends Controller
public function profile($id)
{
- $user = User::find($id);
+ $user = User::findOrFail($id);
$badges = DB::table('badges')->get();
-
- if (!$user) {
- abort(404);
- }
-
$friends = $user->getFriends($perPage = 3);
$data = [
@@ -42,16 +37,12 @@ class PageController extends Controller
'friends' => $friends
];
- return view('pages.profile')->with('data', $data);
+ return view('pages.profile')->with($data);
}
public function profile_friends($id)
{
- $user = User::find($id);
- if (!$user) {
- abort(404);
- }
-
+ $user = User::findOrFail($id);
$friends = $user->getFriends($perPage = 10);
$data = [
@@ -59,13 +50,13 @@ class PageController extends Controller
'friends' => $friends
];
- return view('pages.profile_friends')->with('data', $data);
+ return view('pages.profile_friends')->with($data);
}
public function mutual_friends($id)
{
- $user = User::find($id);
- if (!$user || $user->id == Auth::id()) {
+ $user = User::findOrFail($id);
+ if ($user->id == Auth::id()) {
abort(404);
}
@@ -76,13 +67,13 @@ class PageController extends Controller
'friends' => $friends
];
- return view('pages.mutual_friends')->with('data', $data);
+ return view('pages.mutual_friends')->with($data);
}
public function users(Request $request)
{
if ($request->has('q')) {
- $users = DB::table('users')->where('name', 'LIKE', '%' . $request->q . '%')->paginate(10);
+ $users = User::where('name', 'LIKE', '%' . $request->q . '%')->paginate(10);
} else {
$users = User::paginate(10);
}
diff --git a/resources/views/admin/tree.blade.php b/resources/views/admin/tree.blade.php
index 6361d13..76ec798 100644
--- a/resources/views/admin/tree.blade.php
+++ b/resources/views/admin/tree.blade.php
@@ -26,19 +26,19 @@
name="searchBy" value="name">Search by Username
- @if ($data['user'])
+ @if ($user)
-
User Found: {{ $data['user']->name }}
+
User Found: {{ $user->name }}
-
{{ $data['invited_by'] }}
+ href="{{ route('profile', App\Models\User::where('name', $invited_by)->first()->id) }}" target="_blank">{{ $invited_by }}
- - {{ $data['user']->name }}
+ - {{ $user->name }}
- @foreach ($data['children'] as $child)
+ @foreach ($children as $child)
- {{ $child->name }}
@endforeach
@@ -48,7 +48,7 @@
@endif
@if (!request()->has('q'))
Enter a username or ID.
- @elseif (!$data['user'])
+ @elseif (!$user)
No user was found, check if you entered the correct details.
@endif
diff --git a/resources/views/home.blade.php b/resources/views/home.blade.php
index 20b6c5b..f2ce85f 100644
--- a/resources/views/home.blade.php
+++ b/resources/views/home.blade.php
@@ -22,7 +22,8 @@
@if ($errors->any())
@@ -34,7 +35,7 @@
- @foreach ($data['posts'] as $post)
+ @foreach ($posts as $post)
@endforeach
- @if ($data['posts']->isEmpty())
-
Your feed is empty.
+ @if ($posts->isEmpty())
+
Your feed is empty.
@endif
- {{ $data['posts']->links() }}
+ {{ $posts->links() }}
Friends ({{ Auth::user()->getFriendsCount() }})
@if (Auth::user()->getFriendsCount() > 0)
-
@@ -74,7 +77,7 @@
@if (Auth::user()->getFriendsCount() > 0)
- @foreach ($data['friends'] as $friend)
+ @foreach ($friends as $friend)
 }})
diff --git a/resources/views/pages/mutual_friends.blade.php b/resources/views/pages/mutual_friends.blade.php
index 991cfe1..d34f454 100644
--- a/resources/views/pages/mutual_friends.blade.php
+++ b/resources/views/pages/mutual_friends.blade.php
@@ -1,18 +1,18 @@
@extends('layouts.app')
@section('title')
-
{{ $data['user']->name }}'s Friends (Mutual) - {{ env('APP_NAME') }}
+
{{ $user->name }}'s Friends (Mutual) - {{ env('APP_NAME') }}
@endsection
@section('content')
-
Your Mutual Friends with {{ $data['user']->name }} ({{ Auth::user()->getMutualFriendsCount($data['user']) }})
-
All Friends
+
Your Mutual Friends with {{ $user->name }} ({{ Auth::user()->getMutualFriendsCount($user) }})
+
All Friends
@auth
-
Mutual Friends ({{ Auth::user()->getMutualFriendsCount($data['user']) }})
+
Mutual Friends ({{ Auth::user()->getMutualFriendsCount($user) }})
@endauth
- @foreach ($data['friends'] as $friend)
+ @foreach ($friends as $friend)
@endforeach
- @if (!Auth::user()->getMutualFriendsCount($data['user']))
-
You don't have any mutual friends with {{ $data['user']->name }}.
+ @if (!Auth::user()->getMutualFriendsCount($user))
+
You don't have any mutual friends with {{ $user->name }}.
@endif
- {{ $data['friends']->links() }}
+ {{ $friends->links() }}
@endsection
diff --git a/resources/views/pages/profile.blade.php b/resources/views/pages/profile.blade.php
index 8a9d630..b9365d9 100644
--- a/resources/views/pages/profile.blade.php
+++ b/resources/views/pages/profile.blade.php
@@ -1,54 +1,54 @@
@extends('layouts.app')
@section('title')
-
{{ $data['user']->name }} - {{ env('APP_NAME') }}
+
{{ $user->name }} - {{ env('APP_NAME') }}
@endsection
@section('titlediscord')
-
+
@endsection
@section('descdiscord')
-
+
@endsection
@section('content')
-
{{ $data['user']->name }}
- @if ($data['user']->settings->changed_name)
-
Previous Username: {{ $data['user']->settings->old_name }}
+
{{ $user->name }}
+ @if ($user->settings->changed_name)
+
Previous Username: {{ $user->settings->old_name }}
@endif
- @if (Cache::has('is_online_' . $data['user']->id))
+ @if (Cache::has('is_online_' . $user->id))
Website
@else
Offline - Last Online
- {{ Carbon\Carbon::parse($data['user']->last_seen)->diffForHumans() }}
+ {{ Carbon\Carbon::parse($user->last_seen)->diffForHumans() }}
@endif
- @if (!Auth::guest() && Auth::id() != $data['user']->id)
- @if (Auth::user()->hasSentFriendRequestTo($data['user']))
+ @if (!Auth::guest() && Auth::id() != $user->id)
+ @if (Auth::user()->hasSentFriendRequestTo($user))
Pending...
- @elseif (Auth::user()->hasFriendRequestFrom($data['user']))
-
- @elseif (Auth::user()->isFriendWith($data['user']))
-
@else
-
@endif
- @switch($data['user']->settings->message_preference)
+ @switch($user->settings->message_preference)
@case(2)
-
Message
+
Message
@break
@case(1)
- @if (Auth::user()->isFriendWith($data['user']))
-
Message
+ @if (Auth::user()->isFriendWith($user))
+
Message
@else
Message (Friends Only)
@endif
@@ -60,8 +60,8 @@
- @if (!empty($data['user']->feedposts->last()->status))
-
"{{ $data['user']->feedposts->last()->status }}"
+ @if (!empty($user->feedposts->last()->status))
+ "{{ $user->feedposts->last()->status }}"
@else
"I'm new to ARCHBLOX!"
@@ -69,21 +69,21 @@
- {!! nl2br(e($data['user']->blurb)) !!}
+ {!! nl2br(e($user->blurb)) !!}
@guest
-
Joined: {{ $data['user']->created_at->format('d/m/Y') }}
+ Joined: {{ $user->created_at->format('d/m/Y') }}
@else
- Joined: {{ $data['user']->created_at->format(Auth::user()->settings->date_preference) }}
+ Joined: {{ $user->created_at->format(Auth::user()->settings->date_preference) }}
@endguest
Place Visits: 0
Role
- @foreach ($data['badges'] as $badge)
- @foreach ($data['user']->badges as $user_badge)
+ @foreach ($badges as $badge)
+ @foreach ($user->badges as $user_badge)
@if ($badge->id == $user_badge)